New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[26.x] backports and final changes for v26.1rc2 #29509
Conversation
The MinGW-w64 toolchain links executables to the old msvcrt C Runtime Library that does not support the `x` modifier for the _wfopen() function. Github-Pull: bitcoin#29357 Rebased-From: d2fe905
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
I think #29510 should be backported too, once it's merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 4ac0eb5.
Github-Pull: bitcoin#29412 Rebased-From: 95bddb9
Github-Pull: bitcoin#29412 Rebased-From: e7669e1
Github-Pull: bitcoin#29412 Rebased-From: 66abce1
Github-Pull: bitcoin#29412 Rebased-From: 2d8495e
We preemptively perform a block mutation check before further processing a block message (similar to early sanity checks on other messsage types). The main reasons for this change are as follows: - `CBlock::GetHash()` is a foot-gun without a prior mutation check, as the hash returned only commits to the header but not to the actual transactions (`CBlock::vtx`) contained in the block. - We have observed attacks that abused mutated blocks in the past, which could have been prevented by simply not processing mutated blocks (e.g. bitcoin#27608). Github-Pull: bitcoin#29412 Rebased-From: 49257c0
Github-Pull: bitcoin#29412 Rebased-From: 5bf4f5b
Slight performance improvement by avoiding duplicate work. Github-Pull: bitcoin#29412 Rebased-From: 1ec6bbe
Github-Pull: bitcoin#29412 Rebased-From: d8087ad
…v block Github-Pull: bitcoin#29524 Rebased-From: a1fbde0
…Destination` fails Github-Pull: bitcoin#29510 Rebased-From: 367bb7a
…`getnewaddress` failures Github-Pull: bitcoin#29510 Rebased-From: e073f1d
Can you also add #29529. |
Should fix the GCC compilation portion of bitcoin#29517: bitcoin#29517 (comment). See also: https://www.gnu.org/software/gnulib/manual/html_node/fopencookie.html but note that FreeBSD has supported this function since 11.x. Github-Pull: bitcoin#29529 Rebased-From: 312f338
77e2466
to
b6d006d
Compare
Added #29529. Also updated release notes and added final changes for rc2. |
ACK c68d4d0 |
Includes:
x
modifier infsbridge::fopen
call for MinGW builds #29357getrawchangeaddress
andgetnewaddress
failures should not affect keypools for descriptor wallets #29510Also does: