Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build, test, doc: Temporarily remove Android-related stuff #30049

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented May 6, 2024

Previously, our Android builds were geared towards generating APKs, which relied on Qt. However, after migrating to C++20, compiling for Android became unfeasible due to Qt 5.15's compatibility limitations with NDK only up to r25, which includes an outdated embedded libc++ (see #29360).

All removed stuff will be reinstated after migrating the build system to CMake and upgrading Qt to version 6.x.

This PR makes possible a clean migration to the CMake-based build system as it removes code, which is not used at this moment.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 6, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #29923 (depends: Remove Qt build-time dependencies by laanwj)
  • #29868 (Reintroduce external signer support for Windows by hebasto)
  • #29790 ([DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system -- WIP by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto hebasto marked this pull request as draft May 6, 2024 10:08
@hebasto hebasto marked this pull request as ready for review May 6, 2024 10:10
Previously, our Android builds were geared towards generating APKs,
which relied on Qt. However, after migrating to C++20, compiling for
Android became unfeasible due to Qt 5.15's compatibility limitations
with NDK only up to r25, which includes an outdated embedded libc++.

All removed stuff will be reinstated after migrating the build system to
CMake and upgrading Qt to version 6.x."
@theuni
Copy link
Member

theuni commented May 6, 2024

I guess the idea is that there's basically nothing worth salvaging from our current Android build procedure?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the images are re-added later, it should be done with a clean revert to avoid bloating the repo with identical-looking but binary-differing png blobs.

@hebasto
Copy link
Member Author

hebasto commented May 7, 2024

I guess the idea is that there's basically nothing worth salvaging from our current Android build procedure?

The commit history keeps everything we might need when restoring Android builds.

@laanwj
Copy link
Member

laanwj commented May 9, 2024

I guess the idea is that there's basically nothing worth salvaging from our current Android build procedure?

Not sure about that. i think the idea is that the current stuff is untestable in practice, which meant the CMake transition is blocked on it. E.g. porting it as-is wouldn't result in anything usable nor testable.

i've already cautioned not to go to wild with this and throw away android compatibility in the code, but removing the user facing build system support for now, seems fine with me.

@hebasto
Copy link
Member Author

hebasto commented May 9, 2024

I guess the idea is that there's basically nothing worth salvaging from our current Android build procedure?

Not sure about that. i think the idea is that the current stuff is untestable in practice, which meant the CMake transition is blocked on it. E.g. porting it as-is wouldn't result in anything usable nor testable.

Exactly.

i've already cautioned not to go to wild with this and throw away android compatibility in the code, but removing the user facing build system support for now, seems fine with me.

I agree. No C++ source file is touched in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants