depends: set AR & RANLIB for CMake #30078
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Guix Build (aarch64): cf21ea004d1f8d6d7b53d4ef725083229b18469948439f79872a2b019e8bc966 guix-build-7efd6bf03755/output/aarch64-linux-gnu/SHA256SUMS.part
1fa79040aba310b34075b11eefbdb570dd1f053d25ea432faf9bca596603cabb guix-build-7efd6bf03755/output/aarch64-linux-gnu/bitcoin-7efd6bf03755-aarch64-linux-gnu-debug.tar.gz
a97ee58be3ea463c565ec8098ed3f98a04f70b7a897c2b1961df083f5142e07b guix-build-7efd6bf03755/output/aarch64-linux-gnu/bitcoin-7efd6bf03755-aarch64-linux-gnu.tar.gz
1f4f554289fb8c91acfae3ec521efd3686509b2b38ca7c60979309c14cda29a1 guix-build-7efd6bf03755/output/arm-linux-gnueabihf/SHA256SUMS.part
b957a211d42cbaa7661863e6d34b0130d401678a4ac51f762e64abf61c30c1fc guix-build-7efd6bf03755/output/arm-linux-gnueabihf/bitcoin-7efd6bf03755-arm-linux-gnueabihf-debug.tar.gz
cb7f43e70881008a76d5d0f538d01789c3b583c1d76801ebca1ba0de56074274 guix-build-7efd6bf03755/output/arm-linux-gnueabihf/bitcoin-7efd6bf03755-arm-linux-gnueabihf.tar.gz
a5787586c617cd151afa4bd405cb9c6c775032aaa7d05cd881d30aebc39f8892 guix-build-7efd6bf03755/output/arm64-apple-darwin/SHA256SUMS.part
f58a43941631263ed24e9396f77b016662a05d2ff43e21a3bd960423a195c871 guix-build-7efd6bf03755/output/arm64-apple-darwin/bitcoin-7efd6bf03755-arm64-apple-darwin-unsigned.tar.gz
a8b24481a7224c586129d0fdf1430b8a87ea36aa31a58a25956fd59d48624758 guix-build-7efd6bf03755/output/arm64-apple-darwin/bitcoin-7efd6bf03755-arm64-apple-darwin-unsigned.zip
c073a6f270a9d4068d27db90bda76fcc97bf06ce6bff5a30a1aa31431661a7fb guix-build-7efd6bf03755/output/arm64-apple-darwin/bitcoin-7efd6bf03755-arm64-apple-darwin.tar.gz
a7cb4b5247c7ed567e0513a0ca7a1f2f0fb02375484b6f499b149f75f7d8527a guix-build-7efd6bf03755/output/dist-archive/bitcoin-7efd6bf03755.tar.gz
ce17efab38087a27ef8920de1dcc156c8518b2fe3f8c810b365adc32ce64f2f8 guix-build-7efd6bf03755/output/powerpc64-linux-gnu/SHA256SUMS.part
8f61f8191f201a736bac5a233a518b806d547d7fe2217ae8b41591e26a139747 guix-build-7efd6bf03755/output/powerpc64-linux-gnu/bitcoin-7efd6bf03755-powerpc64-linux-gnu-debug.tar.gz
af0b6b65ed31ad6c4e54f331256a3bb26d722e15b92d0eaff92c9fc8515fee95 guix-build-7efd6bf03755/output/powerpc64-linux-gnu/bitcoin-7efd6bf03755-powerpc64-linux-gnu.tar.gz
7655080a5446c0dca4143606a20a3bb03a460734983baac8283b25fdd580f100 guix-build-7efd6bf03755/output/riscv64-linux-gnu/SHA256SUMS.part
f438102da56dab177b6c37b7d42ddd4351e44b0ccdfee027a7af8fddeaa82b86 guix-build-7efd6bf03755/output/riscv64-linux-gnu/bitcoin-7efd6bf03755-riscv64-linux-gnu-debug.tar.gz
07525dd49e35cc2670a4035f481bcc3db2a3f50260c683cc629a84b2d8c5d344 guix-build-7efd6bf03755/output/riscv64-linux-gnu/bitcoin-7efd6bf03755-riscv64-linux-gnu.tar.gz
d47978740596ecc97ed05eafc50ef1b8b66df3e8675eca66a4a178315990cdc4 guix-build-7efd6bf03755/output/x86_64-apple-darwin/SHA256SUMS.part
867bc83f9a49ff1ff40279d7890b851b7e06076418a339874373d049d57bce45 guix-build-7efd6bf03755/output/x86_64-apple-darwin/bitcoin-7efd6bf03755-x86_64-apple-darwin-unsigned.tar.gz
ea449fc94d5e4c67a00069bc6f3e4c60110edcd1e6886b0a153cc054f95375b6 guix-build-7efd6bf03755/output/x86_64-apple-darwin/bitcoin-7efd6bf03755-x86_64-apple-darwin-unsigned.zip
cb85d8008b3bd60906160f35cb6061b0c8da29b79c1e49c21bab931a82613862 guix-build-7efd6bf03755/output/x86_64-apple-darwin/bitcoin-7efd6bf03755-x86_64-apple-darwin.tar.gz
bb86a06c45ba7adbc8f0ee903524da10cad12e4a20ebe00a6178cf2e0a5bb740 guix-build-7efd6bf03755/output/x86_64-linux-gnu/SHA256SUMS.part
fa55c36952cd103a9497930f519b24a19e048ba393d7e36b120926cfdebe1cd9 guix-build-7efd6bf03755/output/x86_64-linux-gnu/bitcoin-7efd6bf03755-x86_64-linux-gnu-debug.tar.gz
0dd075a1030c110bc16b8f93076e950252ab22aee39e74dfadaa925cab1c5add guix-build-7efd6bf03755/output/x86_64-linux-gnu/bitcoin-7efd6bf03755-x86_64-linux-gnu.tar.gz
80c6b4273311239aaaf43a77ad8567db3d834a7fc8a0239ba0feb111a2617caf guix-build-7efd6bf03755/output/x86_64-w64-mingw32/SHA256SUMS.part
c049d7fba3775a65182c8ed8391dbcda37e065df6810ba1bdf3d99e9c0a53282 guix-build-7efd6bf03755/output/x86_64-w64-mingw32/bitcoin-7efd6bf03755-win64-debug.zip
05edd8c5d0be85a59013caa875bcc0b394d04f250a5cfeb13512c7e0d1af2871 guix-build-7efd6bf03755/output/x86_64-w64-mingw32/bitcoin-7efd6bf03755-win64-setup-unsigned.exe
cff9ab6f39b196afe48e6bb09a87e79266b78a89cb7766aa638f6d74799c9dae guix-build-7efd6bf03755/output/x86_64-w64-mingw32/bitcoin-7efd6bf03755-win64-unsigned.tar.gz
d244c84b83e1f98e2ea5ca0019d1da37326b6d6394511c2b9fe25d912182bb10 guix-build-7efd6bf03755/output/x86_64-w64-mingw32/bitcoin-7efd6bf03755-win64.zip |
hebasto
reviewed
May 10, 2024
depends/funcs.mk
Outdated
Comment on lines
182
to
183
| AR="$$($(1)_ar)" \ | ||
| RANLIB="$$($(1)_ranlib)" \ |
There was a problem hiding this comment.
In contrary to the CC and CXX environment variables, CMake docs do not mention that AR and RANLIB are honored as well.
I suggest to use CMAKE_AR and CMAKE_RANLIB instead.
There was a problem hiding this comment.
I tried both of those before landing on this change, and they didn't seem to work properly. Happy to have a look if you can show a patch that works. There's also no CMAKE_NM, so that isn't going to work if we want to pass that through as well.
There was a problem hiding this comment.
Hmm, looking at the docs and playing around, CMAKE_AR seems more correct to me too. It seems like it should work correctly, what was the problem?
There's also CMAKE_C_COMPILER_AR which may be more correct?
There was a problem hiding this comment.
There's also no CMAKE_NM, so that isn't going to work if we want to pass that through as well.
I see CMAKE_NM in my CMakeCache.txt, maybe it's just not documented for some reason?
There was a problem hiding this comment.
Hmm, looking at the docs and playing around,
CMAKE_ARseems more correct to me too. It seems like it should work correctly, what was the problem?
It seems CMAKE_AR is interpreted as relative to the build dir for some reason. What works for me is:
-DCMAKE_AR=`which ar`
There was a problem hiding this comment.
There was a problem hiding this comment.
What works for me is:
Bug here: https://gitlab.kitware.com/cmake/cmake/-/issues/18087
Given the bug report is 5 years old, I can't imagine CMake is going to either "fix" or change things now. I can switch to CMAKE_ using which if that is what's preferred. Will add CMAKE_NM even if that's missing from the CMake docs. Maybe we can upstream a fix for that as well. Whatever will move things forward.
There was a problem hiding this comment.
Thanks, I think this is the way to go.
|
Guix build (aarch64): |
fanquake
force-pushed
the
set_cmake_ar_global
branch
from
7efd6bf
to
019ad73
Compare
|
I was able to build depends on macOS 14.4.1, and build and run QT. Guix hashes (on AMD Ubuntu): |
TheCharlatan
approved these changes
May 13, 2024
There was a problem hiding this comment.
ACK 019ad73
Guix build (aarch64):
bdbb759d06e9766c5aa29a9ee1cea6f021d50618e1abe4732ae0120c4b444829 guix-build-019ad7327c39/output/aarch64-linux-gnu/SHA256SUMS.part
82aa7b4af365dde09b7fe435bd20432aa59168cb448f7a8cb898a8acb6178453 guix-build-019ad7327c39/output/aarch64-linux-gnu/bitcoin-019ad7327c39-aarch64-linux-gnu-debug.tar.gz
93c539e8c42ff767e46fc3f501cf9d543b954202372c930c177ff22eea6037f5 guix-build-019ad7327c39/output/aarch64-linux-gnu/bitcoin-019ad7327c39-aarch64-linux-gnu.tar.gz
caf90481a3a2ced418e7a6d621745e8860ccaff3288268ab4b3d90e52904d123 guix-build-019ad7327c39/output/arm-linux-gnueabihf/SHA256SUMS.part
aec8688b03f90ad21bdfa4e2019af856af42ca040012aad7e228ae02c0fa6f33 guix-build-019ad7327c39/output/arm-linux-gnueabihf/bitcoin-019ad7327c39-arm-linux-gnueabihf-debug.tar.gz
ebbf788edf313190a5a1204ef491c84879ac28f018b5eae43bf700f7fb5a5ec5 guix-build-019ad7327c39/output/arm-linux-gnueabihf/bitcoin-019ad7327c39-arm-linux-gnueabihf.tar.gz
3fb1377d021e150ccd2d652ec2d0c2116bf983b2e5dfb4097c9aedfb1f556cb5 guix-build-019ad7327c39/output/arm64-apple-darwin/SHA256SUMS.part
b8be9a2a93eb98382e71980a7baa5914fbb7cb956823b7186582a2645bab48d5 guix-build-019ad7327c39/output/arm64-apple-darwin/bitcoin-019ad7327c39-arm64-apple-darwin-unsigned.tar.gz
9368e54a4d0cdc1b7882a0b2925b4f3615623d46f8886ce62f319e8674336956 guix-build-019ad7327c39/output/arm64-apple-darwin/bitcoin-019ad7327c39-arm64-apple-darwin-unsigned.zip
abc5a5b11139c1a88a8ed3d88359d9ef422faf2afdf4ba1cdaef9759fcb60a44 guix-build-019ad7327c39/output/arm64-apple-darwin/bitcoin-019ad7327c39-arm64-apple-darwin.tar.gz
63cb416c094a0c5b37c4abfd75ef5daec3fe25b2e2a98d72cbfe046239aae6d1 guix-build-019ad7327c39/output/dist-archive/bitcoin-019ad7327c39.tar.gz
cd18826f64b576c20c998172bd8afe1a5d4859e00996109485901eaa95813a17 guix-build-019ad7327c39/output/powerpc64-linux-gnu/SHA256SUMS.part
a97107c53f7945556bf918bcbd727e898f5efa24c89b41a9a57ec15dad28eaa8 guix-build-019ad7327c39/output/powerpc64-linux-gnu/bitcoin-019ad7327c39-powerpc64-linux-gnu-debug.tar.gz
acd9b140f265bb5065bac329eb2275e51f97993e427635f03e7e88d628fbca2b guix-build-019ad7327c39/output/powerpc64-linux-gnu/bitcoin-019ad7327c39-powerpc64-linux-gnu.tar.gz
c9d56a5ae6c26bc9ac3ad4844619ff039948840a2aebc88add68dd806d21fd2c guix-build-019ad7327c39/output/riscv64-linux-gnu/SHA256SUMS.part
a590236bb5ad600957b1a8b5552d13882909a7dfc73ed98e03df4b216cce7a01 guix-build-019ad7327c39/output/riscv64-linux-gnu/bitcoin-019ad7327c39-riscv64-linux-gnu-debug.tar.gz
a18cdebe4c1c21df0778152f98102ad69cd9a5746b168e8d430eca26f557dd96 guix-build-019ad7327c39/output/riscv64-linux-gnu/bitcoin-019ad7327c39-riscv64-linux-gnu.tar.gz
9226892d4fdb0feaefe95350d3f639545d2b0f8a14e029c4b5e046ed2fb1f173 guix-build-019ad7327c39/output/x86_64-apple-darwin/SHA256SUMS.part
645d033d1c23f223c4059fc542ca9a9692e7842b715afaf30b7a53f2130828b6 guix-build-019ad7327c39/output/x86_64-apple-darwin/bitcoin-019ad7327c39-x86_64-apple-darwin-unsigned.tar.gz
040b5f48e7f5e051a6580fe749040953d7b711b38d78370b6722bbf1cf5cdc75 guix-build-019ad7327c39/output/x86_64-apple-darwin/bitcoin-019ad7327c39-x86_64-apple-darwin-unsigned.zip
2725baac8beef25362d03a7b6dcb815da2c2761db949737e6b8c3ce5ef523f05 guix-build-019ad7327c39/output/x86_64-apple-darwin/bitcoin-019ad7327c39-x86_64-apple-darwin.tar.gz
5bf08ae92bfeb3b6c538306c1fbdc06232687c41a483f0c2d1cd86061be470a9 guix-build-019ad7327c39/output/x86_64-linux-gnu/SHA256SUMS.part
aaf5a3fe6a7c62d66d0a4fb7e8afcba434e3e1919ae9b8fbe31d5e7f67448703 guix-build-019ad7327c39/output/x86_64-linux-gnu/bitcoin-019ad7327c39-x86_64-linux-gnu-debug.tar.gz
022e4edc6c0282c563cfb1cfdb46ab6ea5d17691c1804d814da9686a24ba5bfd guix-build-019ad7327c39/output/x86_64-linux-gnu/bitcoin-019ad7327c39-x86_64-linux-gnu.tar.gz
1b5e801fab4385d2ca5a7c0724eab6e842598de24f1fa1d4e39ae781b8a441eb guix-build-019ad7327c39/output/x86_64-w64-mingw32/SHA256SUMS.part
8d7cfe8b63289ccd5d20dee89942b21ecafebbac2b4dceb93280325001b465b9 guix-build-019ad7327c39/output/x86_64-w64-mingw32/bitcoin-019ad7327c39-win64-debug.zip
f41ebb6b11d88baf799183823c956c070935324b62f31923aead45556bf5fab5 guix-build-019ad7327c39/output/x86_64-w64-mingw32/bitcoin-019ad7327c39-win64-setup-unsigned.exe
017cc110143e52f4cc4a0cdabf85f718e8d372a58d4582d0bed7b9c45cf4c0e5 guix-build-019ad7327c39/output/x86_64-w64-mingw32/bitcoin-019ad7327c39-win64-unsigned.tar.gz
83cbe899bba23087bce7f0ec139da64aa30c1ce710b49304ba7cc5925043342b guix-build-019ad7327c39/output/x86_64-w64-mingw32/bitcoin-019ad7327c39-win64.zip
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]
|
|
Guix build (aarch64): bdbb759d06e9766c5aa29a9ee1cea6f021d50618e1abe4732ae0120c4b444829 guix-build-019ad7327c39/output/aarch64-linux-gnu/SHA256SUMS.part
82aa7b4af365dde09b7fe435bd20432aa59168cb448f7a8cb898a8acb6178453 guix-build-019ad7327c39/output/aarch64-linux-gnu/bitcoin-019ad7327c39-aarch64-linux-gnu-debug.tar.gz
93c539e8c42ff767e46fc3f501cf9d543b954202372c930c177ff22eea6037f5 guix-build-019ad7327c39/output/aarch64-linux-gnu/bitcoin-019ad7327c39-aarch64-linux-gnu.tar.gz
caf90481a3a2ced418e7a6d621745e8860ccaff3288268ab4b3d90e52904d123 guix-build-019ad7327c39/output/arm-linux-gnueabihf/SHA256SUMS.part
aec8688b03f90ad21bdfa4e2019af856af42ca040012aad7e228ae02c0fa6f33 guix-build-019ad7327c39/output/arm-linux-gnueabihf/bitcoin-019ad7327c39-arm-linux-gnueabihf-debug.tar.gz
ebbf788edf313190a5a1204ef491c84879ac28f018b5eae43bf700f7fb5a5ec5 guix-build-019ad7327c39/output/arm-linux-gnueabihf/bitcoin-019ad7327c39-arm-linux-gnueabihf.tar.gz
3fb1377d021e150ccd2d652ec2d0c2116bf983b2e5dfb4097c9aedfb1f556cb5 guix-build-019ad7327c39/output/arm64-apple-darwin/SHA256SUMS.part
b8be9a2a93eb98382e71980a7baa5914fbb7cb956823b7186582a2645bab48d5 guix-build-019ad7327c39/output/arm64-apple-darwin/bitcoin-019ad7327c39-arm64-apple-darwin-unsigned.tar.gz
9368e54a4d0cdc1b7882a0b2925b4f3615623d46f8886ce62f319e8674336956 guix-build-019ad7327c39/output/arm64-apple-darwin/bitcoin-019ad7327c39-arm64-apple-darwin-unsigned.zip
abc5a5b11139c1a88a8ed3d88359d9ef422faf2afdf4ba1cdaef9759fcb60a44 guix-build-019ad7327c39/output/arm64-apple-darwin/bitcoin-019ad7327c39-arm64-apple-darwin.tar.gz
63cb416c094a0c5b37c4abfd75ef5daec3fe25b2e2a98d72cbfe046239aae6d1 guix-build-019ad7327c39/output/dist-archive/bitcoin-019ad7327c39.tar.gz
cd18826f64b576c20c998172bd8afe1a5d4859e00996109485901eaa95813a17 guix-build-019ad7327c39/output/powerpc64-linux-gnu/SHA256SUMS.part
a97107c53f7945556bf918bcbd727e898f5efa24c89b41a9a57ec15dad28eaa8 guix-build-019ad7327c39/output/powerpc64-linux-gnu/bitcoin-019ad7327c39-powerpc64-linux-gnu-debug.tar.gz
acd9b140f265bb5065bac329eb2275e51f97993e427635f03e7e88d628fbca2b guix-build-019ad7327c39/output/powerpc64-linux-gnu/bitcoin-019ad7327c39-powerpc64-linux-gnu.tar.gz
c9d56a5ae6c26bc9ac3ad4844619ff039948840a2aebc88add68dd806d21fd2c guix-build-019ad7327c39/output/riscv64-linux-gnu/SHA256SUMS.part
a590236bb5ad600957b1a8b5552d13882909a7dfc73ed98e03df4b216cce7a01 guix-build-019ad7327c39/output/riscv64-linux-gnu/bitcoin-019ad7327c39-riscv64-linux-gnu-debug.tar.gz
a18cdebe4c1c21df0778152f98102ad69cd9a5746b168e8d430eca26f557dd96 guix-build-019ad7327c39/output/riscv64-linux-gnu/bitcoin-019ad7327c39-riscv64-linux-gnu.tar.gz
9226892d4fdb0feaefe95350d3f639545d2b0f8a14e029c4b5e046ed2fb1f173 guix-build-019ad7327c39/output/x86_64-apple-darwin/SHA256SUMS.part
645d033d1c23f223c4059fc542ca9a9692e7842b715afaf30b7a53f2130828b6 guix-build-019ad7327c39/output/x86_64-apple-darwin/bitcoin-019ad7327c39-x86_64-apple-darwin-unsigned.tar.gz
040b5f48e7f5e051a6580fe749040953d7b711b38d78370b6722bbf1cf5cdc75 guix-build-019ad7327c39/output/x86_64-apple-darwin/bitcoin-019ad7327c39-x86_64-apple-darwin-unsigned.zip
2725baac8beef25362d03a7b6dcb815da2c2761db949737e6b8c3ce5ef523f05 guix-build-019ad7327c39/output/x86_64-apple-darwin/bitcoin-019ad7327c39-x86_64-apple-darwin.tar.gz
5bf08ae92bfeb3b6c538306c1fbdc06232687c41a483f0c2d1cd86061be470a9 guix-build-019ad7327c39/output/x86_64-linux-gnu/SHA256SUMS.part
aaf5a3fe6a7c62d66d0a4fb7e8afcba434e3e1919ae9b8fbe31d5e7f67448703 guix-build-019ad7327c39/output/x86_64-linux-gnu/bitcoin-019ad7327c39-x86_64-linux-gnu-debug.tar.gz
022e4edc6c0282c563cfb1cfdb46ab6ea5d17691c1804d814da9686a24ba5bfd guix-build-019ad7327c39/output/x86_64-linux-gnu/bitcoin-019ad7327c39-x86_64-linux-gnu.tar.gz
1b5e801fab4385d2ca5a7c0724eab6e842598de24f1fa1d4e39ae781b8a441eb guix-build-019ad7327c39/output/x86_64-w64-mingw32/SHA256SUMS.part
8d7cfe8b63289ccd5d20dee89942b21ecafebbac2b4dceb93280325001b465b9 guix-build-019ad7327c39/output/x86_64-w64-mingw32/bitcoin-019ad7327c39-win64-debug.zip
f41ebb6b11d88baf799183823c956c070935324b62f31923aead45556bf5fab5 guix-build-019ad7327c39/output/x86_64-w64-mingw32/bitcoin-019ad7327c39-win64-setup-unsigned.exe
017cc110143e52f4cc4a0cdabf85f718e8d372a58d4582d0bed7b9c45cf4c0e5 guix-build-019ad7327c39/output/x86_64-w64-mingw32/bitcoin-019ad7327c39-win64-unsigned.tar.gz
83cbe899bba23087bce7f0ec139da64aa30c1ce710b49304ba7cc5925043342b guix-build-019ad7327c39/output/x86_64-w64-mingw32/bitcoin-019ad7327c39-win64.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #21778. Should be more correct in any case.