Testnet difficulty calculation changes, to take effect Feb 15 2012 #686
Conversation
|
|
||
| // Only change once per interval | ||
| if ((pindexLast->nHeight+1) % nInterval != 0) | ||
| { | ||
| // Special rules for testnet after 1 Jan 2012: |
There was a problem hiding this comment.
Why inside the interval check? If we are on the cusp of an interval, why shouldn't we allow min-diff blocks?
|
Other than that one concern, ACK |
|
At the same time, I propose adjusting the testnet base58 versions to match with the new proposed base58 version spec. |
|
RE: why keep the regular-difficulty-every-2016-blocks: Because if you don't, and hashing power drops, then it will never adjust downward properly because the common case for non-cusp blocks is "find the last block with something other than minimum work and return its difficulty." Example: Imagine difficulty is at 1111 before block 201600, and that block ends up taking 60 minutes to find. Imagine the normal difficulty adjustment would drop difficulty to 600. If we allow block 201600 to have difficulty 1, then block 201601 would also be looked for at difficulty 1111, because there's no previous block with the new difficulty. I wrote the code that way so testnet is as close to mainnet as possible; I didn't want a completely different testnet non-cusp-block calculation (yes, I COULD figure out what the last difficulty adjustment interval was and factor out the difficulty computation into yet another method... benefit doesn't seem worth the extra code complexity). RE: adjusting testnet base58 version: okey doke. What's the right number for testnet under your scheme? 192? |
|
mmm, fair enough |
|
Yes, 192 for testnet pubkey-addresses. 196 for testnet script-addresses (OP_EVAL). |
| return nProofOfWorkLimit; | ||
| else | ||
| { | ||
| // Return the last non-min-difficulty-block |
There was a problem hiding this comment.
What if the correct difficulty for this interval is min difficulty? Wouldn't this code return something higher from a block that it finds in the previous inteval? It should probably stop at the interval change and use the difficulty there.
const CBlockIndex* pindex = pindexLast;
while (pindex->pprev && pindex->nHeight % nInterval != 0 && pindex->nBits == nProofOfWorkLimit)
pindex = pindex->pprev;
return pindex->nBits;
|
The new anti-orphan-flood code won't break this, will it? |
|
coblee: Nice catch! You're right, this would prevent difficulty from ever dropping all the way down to min difficulty. luke-jr: Nice catch! You're right, the orphan block DoS code needs to take into account this change. I won't have time to fix this until I'm back next week. |
|
Code updated/rebased to fix the issues pointed out by coblee and luke-jr. |
|
Is this going to be merged before 15 Jan? ;) |
| // Testnet has min-difficulty blocks | ||
| // after nTargetSpacing*2 time between blocks: | ||
| if (fTestNet && nTime > nTargetSpacing*2) | ||
| return bnProofOfWorkLimit.GetCompact(); |
There was a problem hiding this comment.
I'm not sure whether this affects anything, but this does not check pblock->nTime > 1326585600 like the other one.
There was a problem hiding this comment.
It is OK-- the code that calls ComputeMinWork call pblock->GetBlockTime() which just return pblock->nTime.
Allow mining of min-difficulty blocks if 20 minutes have gone by without mining a regular-difficulty block. Normal rules apply every 2016 blocks, though, so there may be a very-slow-to-confirm block at the difficulty-adjustment blocks.
fix test suite
[Backport to Release PR#685] Do not continue if header will not connect
Allow mining of min-difficulty blocks if 20 minutes have gone by without mining a regular-difficulty block.
Normal rules apply every 2016 blocks, though, so there may be a very-slow-to-confirm block at the difficulty-adjustment blocks (once per month, assuming testnet is in it's normal "difficulty too high for number of people mining it" state).
This will almost certainly cause a testnet blockchain split after Jan 15. I'll update the Testnet Faucet, I'll ask theymos if he can update the testnet block explorer bitcoind.
(date slipped from Jan 1 to Feb 15)