Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] fix {master,replica,sentinel}.persistence.labels #25946

Closed
wants to merge 1 commit into from

Conversation

jbertozzi
Copy link
Contributor

Description of the change

This commit add consistency with others bitnami charts (i.e.: postgresql)

Benefits

Fix pvc labels.

Possible drawbacks

No drawback.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

This commit add consistency with others bitnami charts (i.e.: [postgresql](https://github.com/jbertozzi/charts/blob/master/bitnami/postgresql/templates/primary/statefulset.yaml#L668-L670))

Signed-off-by: Jérémy Bertozzi <jeremy.bertozzi@gmail.com>
@github-actions github-actions bot added redis triage Triage is needed labels May 16, 2024
@github-actions github-actions bot requested a review from javsalgar May 16, 2024 11:39
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 16, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 16, 2024
@github-actions github-actions bot removed the request for review from javsalgar May 16, 2024 13:26
@github-actions github-actions bot requested a review from jotamartos May 16, 2024 13:26
@jotamartos
Copy link
Contributor

Hi @jbertozzi,

Thank you for taking the time to create this PR. However, I need to decline it because spec.volumeClaimTemplates.metadata.labels field is inmutable and our plan is to remove support for persistence.labels at all given they're highly problematic and users usually introduce backwards incompatibilities by mistake.

You can find more information about this in this other thread

#22364

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/redis] persistence.labels are ignored
4 participants