Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Areas for performance improvement #65

Open
charlesgregory opened this issue Apr 21, 2021 · 2 comments
Open

Areas for performance improvement #65

charlesgregory opened this issue Apr 21, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@charlesgregory
Copy link
Contributor

If we are ever going to have a "performance mode", we need to know what areas need compiler switches for performance. This could be done either by benchmarking or by simple algorithmic analysis (eyeballing it). (somewhat related to #56)

@charlesgregory charlesgregory added enhancement New feature or request help wanted Extra attention is needed labels Apr 21, 2021
@jblachly
Copy link
Member

TBH I think we just need to run some client programs on big datasets and then do performance analysis flamegraphs, callgraphs , whatever

In some cases, poor performance may be out of our control, for example, the string handling in htslib for VCFs was super bad until 1.11 or 1.12 IIRC

@jblachly jblachly added the question Further information is requested label Apr 21, 2021
@charlesgregory
Copy link
Contributor Author

From my attempts at making SIMD work for my own code with dhtslib, bgzf decompression is almost always the biggest bottleneck (when dealing with bam files). So there may be very little to be gained without the hassle of just resorting to C (and even then those gains are likely small).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants