Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inital support for user-selectable cursors #59

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sp1ritCS
Copy link
Contributor

You can now select the cursor notekit uses for a specific tool in the config. Key: root->tool->[text/pen/eraser/select]

And I've improved the Preferences, (the new things are just there graphically, so they are not yet working)
image

@blackhole89
Copy link
Owner

Thanks! Some notes-

  • Looks like the size group based layout broke. (I was aiming to have all the UI elements actually representing modifiable settings line up in a column.)

  • Since I already made CSDs configurable for the main application (to better accommodate WMs/setups in which they are not well-supported or natural), it's a bit odd to now turn around and make it mandatory for the preferences window... what happens in a setting such as Wayland if there is no headerbar? Does the WM decorate the window as in X11?

  • I think cursors or tool_cursors would be a better name for the JSON subobject describing the cursors than tool.

  • The relevant config entries should be added to default_config.json.

@sp1ritCS
Copy link
Contributor Author

sp1ritCS commented Nov 15, 2020

Looks like the size group based layout broke. (I was aiming to have all the UI elements actually representing modifiable settings line up in a column.)

That was intentional? I thought that just looked odd (especially as the text below it started not below it but on the left side). I prefer it the way it is now.


Does the WM decorate the window as in X11?

Depends on the compositor, wlroots / kwinft can do this, mutter can't. But because this is GTK, gtk just renders the titlebar as CSD on mutter.

On the topic of making them "mandaritory", they should be well-supported because its csd; but I see why it isn't natural. - but they are settings afterall, its not that often that someone needs to change something.


I'll change the key to tool_cursors and add it to the config. (Even tho the key should get added automatically with the fallback value when notekit tries to read the value and it isn't found.

@blackhole89
Copy link
Owner

I'll look into merging this in a few days (I'm willing to give up my idiosyncratic preference on the checkboxes, but I do want to adjust it so at least the combo boxes for the Base Directory and the Pen Cursor are aligned - i.e. those labels should go into the size group), as right now cross-checking the flatpak support and attendant build system/dependency changes should probably take up all the bandwidth I can spare here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants