Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/x s3 bundle/256 uploads bundle abstractisation #274

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

y-moufakkr
Copy link
Collaborator

@y-moufakkr y-moufakkr commented Apr 18, 2022

closes #256

  • Abstract the file storage
  • Leave S3 and Local as two valid options
  • Create the possibility of using any storage
  • Leave the possibility of having multiple storages
  • docs
  • Create the posibility of having different contexts, like 3 s3 storages, 1 azure, and 2 local.
  • unit tests
  • rename the bundle in code and in docs

@theodorDiaconu
Copy link
Contributor

@y-moufakkr can you resolve the conflicts. is this PR ready?

@y-moufakkr y-moufakkr changed the title [WIP] Feature/x s3 bundle/256 uploads bundle abstractisation [R] Feature/x s3 bundle/256 uploads bundle abstractisation Jul 18, 2022
@y-moufakkr
Copy link
Collaborator Author

@theodorDiaconu do we need to create another bundle for this ? and keep x-s3-bundle as it is just like xpassword and xauth ?

@theodorDiaconu theodorDiaconu changed the title [R] Feature/x s3 bundle/256 uploads bundle abstractisation [WIP] Feature/x s3 bundle/256 uploads bundle abstractisation Nov 11, 2022
@theodorDiaconu
Copy link
Contributor

It's crucial that we have more contexts for upload. We should have a 'default' one and other named ones. Most of the times apps will use just one so a method like getUploader(name = "default") {} and returns an UploaderInterface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploads Bundle Abstractisation
2 participants