[R] fix (x-bundle): add deepsync to the inseret/update executors #281
Conversation
|
I don’t understand how you changes are allowing the executor to deepsync the inpu. All it does is Fetch the inserted / updated doc and deepsync it, which will have no effect (unless you inserting fields in the root document, which is undesirable) |
y-moufakkr
changed the title
y-moufakkr
force-pushed
the
feat/x-bundle/260-deepsync-in-executors
branch
from
d70b1b8
to
a5ccae5
Compare
y-moufakkr
changed the title
| @@ -155,6 +156,7 @@ export function CheckDocumentExists<T>( | |||
| */ | |||
| export function ToDocumentInsert<T>( | |||
| collectionClass: Constructor<Collection<T>>, | |||
| options?: InsertUpdateExecutorOptions, | |||
There was a problem hiding this comment.
This introduces breaking changes. Let's use either field, or { field: "xxx", deepSync: "xxx" })
There was a problem hiding this comment.
extend() I don't think it's ever used. But add it to those options, so it's a string (field) or an object of options.
theodorDiaconu
changed the title
y-moufakkr
changed the title
| if (typeof options.deepSync !== "boolean") { | ||
| const deepSyncFields = {}; | ||
| (Array.isArray(options.deepSync) | ||
| ? options.deepSync |
There was a problem hiding this comment.
So we are specifying which fields we're going to deep sync? How does this help us, since document[key] already exists and then you merge it below, won't it be like that everytime?
There was a problem hiding this comment.
For now only allow deepSync as bool.
…/x-bundle/260-deepsync-in-executors
close #260