[WIP] fix core: token naming + container.get chain path #302

y-moufakkr · 2022-06-06T08:22:56Z

tests
infinite chain possibility? (self-referencing error, infinite loop error and show path)
descriptive exception with chain path.

closes #294

a fix core: add services not found chain to the err object

theodorDiaconu · 2023-09-23T18:05:25Z

packages/core/src/di.ts

+      }
+    } catch (e) {
+      const key = (id as any).name ? (id as any).name : id;
+      e.ServiceNotFoundErrorChain = e.ServiceNotFoundErrorChain


better to do here something like a push to chain, and leave 'rendering' at the end level not at the 'construct' level. We should also have tests in place to ensure chain path is ok.

fix core: token naming + container.get chain path

bfd2b74

a fix core: add services not found chain to the err object

theodorDiaconu reviewed Sep 23, 2023

View reviewed changes

theodorDiaconu changed the title ~~[R]fix core: token naming + container.get chain path~~ [WIP] fix core: token naming + container.get chain path Sep 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] fix core: token naming + container.get chain path #302

[WIP] fix core: token naming + container.get chain path #302

y-moufakkr commented Jun 6, 2022 •

edited by theodorDiaconu

theodorDiaconu Sep 23, 2023

[WIP] fix core: token naming + container.get chain path #302

Are you sure you want to change the base?

[WIP] fix core: token naming + container.get chain path #302

Conversation

y-moufakkr commented Jun 6, 2022 • edited by theodorDiaconu

theodorDiaconu Sep 23, 2023

Choose a reason for hiding this comment

y-moufakkr commented Jun 6, 2022 •

edited by theodorDiaconu