Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link-local detection #1061

Merged
merged 2 commits into from Jun 30, 2023
Merged

Fix link-local detection #1061

merged 2 commits into from Jun 30, 2023

Conversation

Williangalvani
Copy link
Member

fix #1054
fix #1059

this might mean we're dropping support for ubunut 18.04? not sure. but we at least get a build. 18.04 was dropped from actions.

@Williangalvani Williangalvani changed the title Fixip Fix link-local detection Jun 10, 2023
@patrickelectric
Copy link
Member

patrickelectric commented Jun 29, 2023 •
edited

@Williangalvani check ci code style check

@patrickelectric
Copy link
Member

@Williangalvani

/home/runner/work/ping-viewer/ping-viewer/src/sensor/ping360asciiprotocol.h:49: warning: Member removeLeadingZerosFromIP(const QString &line) (function) of class Ping360AsciiProtocol is not documented.
Missing documentation in code!

@patrickelectric patrickelectric merged commit b129811 into bluerobotics:master Jun 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix deployment for linux Ping360 not recognized over direct ethernet connection
2 participants
@Williangalvani @patrickelectric