Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python asyncio_ioloop examples still use ZMQEventLoop #793

Open
jwiede opened this issue Jan 15, 2020 · 2 comments
Open

Python asyncio_ioloop examples still use ZMQEventLoop #793

jwiede opened this issue Jan 15, 2020 · 2 comments

Comments

@jwiede
Copy link

jwiede commented Jan 15, 2020

Fix to pyzmq (zeromq/pyzmq#1021), added to pyzmq master in 2017, removed need for custom ZMQEventLoop in order to support use of alternative (uvloop, etc) coroutine engines. However, Zguide examples (under examples/Python/asyncio_ioloop, see patho{pub,sub}.py for two such cases) are still using outdated ZMQEventLoop-based approach, which also results in examples being more complex than needed (decorators + non-async-based coroutines, etc.).

Please use current pyzmq asyncio example code instead in Zguide.

Also filed as pyzmq issue in zeromq/pyzmq#1352 -- it wasn't clear who's actually responsible for Python examples in Zguide, and maintains their parity with pyzmq code examples.

@jwiede jwiede changed the title asyncio_ioloop examples still use ZMQEventLoop Pyzmq asyncio_ioloop examples still use ZMQEventLoop Jan 15, 2020
@jwiede jwiede changed the title Pyzmq asyncio_ioloop examples still use ZMQEventLoop Python asyncio_ioloop examples still use ZMQEventLoop Jan 15, 2020
@sappo
Copy link
Member

sappo commented Jan 16, 2020

Hi @jwiede,
There is no maintainer for those examples. If you can fix them please update them and open a PR. Thanks :)

@jwiede
Copy link
Author

jwiede commented Jan 21, 2020

(peril-sensitive sunglasses go black)

Heya @sappo, this is one of those "you touch, you own" situations, and you're trying to trick me into touching it, aren't you? (g)

Once I get a chance, I will do so. Not a code contributor (yet), so need to understand the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants