Remove internal zmq_poll implementations for eventloop integration #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
changed the title
enables getting FD in eventloops like tornado
leave deprecations in their place
leave deprecations in place
instance no longer creates deprecated class
for more consistent type, warning behavior still doesn’t do anything zmq-specific, but IOLoop.instance() produces a ZMQIOLoop reliably.
instead of repeated warnings for install and instantiation
minrk
changed the title
|
Thank you @minrk! 👍 |
Closed
|
yay, this is yuuge :) |
This was referenced Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, use edge-triggered zmq.FD.
This enables integration with any eventloop supported by asyncio, tornado, etc. (closes #894)
After experience of numerous bugs in zmq.green, this can result in hangs if not done super carefully, but it seems worth it at this point with the proliferation of asyncio implementations.
zmq.EVENTS, which can consume events on the FD.