Fix implicitly-declared copy constructor is deprecated in planar_pixe…

…l_reference.hpp Add TODO comment on: What is the purpose of returning via const reference?
boostorg · Jul 22, 2019 · f2d0958 · f2d0958
1 parent f027895
commit f2d0958
Showing 1 changed file with 18 additions and 14 deletions.
diff --git a/include/boost/gil/planar_pixel_reference.hpp b/include/boost/gil/planar_pixel_reference.hpp
@@ -82,12 +82,30 @@ struct planar_pixel_reference : detail::homogeneous_color_base
         : parent_t(v0, v1, v2, v3, v4, v5)
     {}
 
+    planar_pixel_reference(planar_pixel_reference const& p) : parent_t(p) {}
+
+    // TODO: What is the purpose of returning via const reference?
+    auto operator=(planar_pixel_reference const& p) const -> planar_pixel_reference const&
+    {
+        static_copy(p, *this);
+        return *this;
+    }
+
     template <typename Pixel>
     planar_pixel_reference(Pixel const& p) : parent_t(p)
     {
          check_compatible<Pixel>();
     }
 
+    // TODO: What is the purpose of returning via const reference?
+    template <typename Pixel>
+    auto operator=(Pixel const& p) const -> planar_pixel_reference const&
+    {
+        check_compatible<Pixel>();
+        static_copy(p, *this);
+        return *this;
+    }
+
     // PERFORMANCE_CHECK: Is this constructor necessary?
     template <typename ChannelV, typename Mapping>
     planar_pixel_reference(pixel<ChannelV, layout<ColorSpace, Mapping>>& p)
@@ -102,20 +120,6 @@ struct planar_pixel_reference : detail::homogeneous_color_base
         : parent_t(p, diff)
     {}
 
-    auto operator=(planar_pixel_reference const& p) const -> planar_pixel_reference const&
-    {
-        static_copy(p, *this);
-        return *this;
-    }
-
-    template <typename Pixel>
-    auto operator=(Pixel const& p) const -> planar_pixel_reference const&
-    {
-        check_compatible<Pixel>();
-        static_copy(p, *this);
-        return *this;
-    }
-
 // This overload is necessary for a compiler implementing Core Issue 574
 // to prevent generation of an implicit copy assignment operator (the reason
 // for generating implicit copy assignment operator is that according to