This repository has been archived by the owner on Jan 1, 2021. It is now read-only.
Less permissive file modes for /Users mount #1152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mounting C:\Users and the like, at least on Windows (I'm not sure if this is the same if the host OS is OSX in which case this might need adjusting) all files are given mode `777`. This is a problem for a few reasons that I listed in sagemath/docker-images#19 Setting `600` for files seems to make sense, since for directories under `/Users`/`C:\Users` most files should be private anyways. I'm split on whether files should be executable or not, but ultimately going with not to be on the safe side.
|
I'm hesitant on this one given that it's technically a breaking change. 😞 (Bind-mounting this directory into various containers running as various UIDs is likely to cause all sorts of trouble, for example.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mounting C:\Users and the like, at least on Windows (I'm not sure if this is the same if the host OS is OSX in which case this might need adjusting) all files are given mode
777. This is a problem for a few reasons that I listed in sagemath/docker-images#19Setting
600for files seems to make sense, since for directories under/Users/C:\Usersmost files should be private anyways. I'm split on whether files should be executable or not, but ultimately going with not to be on the safe side.