Refacto delete screenshot #856
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into delete_screenshot
… that can be parametrized given Actions callback
This way each modal can have its own independent callback (and we don't broadcast).
See how register Async is moved into the childrens.
General thinking, we had:
S1(DS1) -> onDelete() --> DS1.delete --> DS1.success --> A.onDeleteSuccess --> S1.onDeleteSuccess
--> S2.onDeleteSuccess
S2(DS1) -> onDelete() --> DS1.delete --> DS1.success --> A.onDeleteSuccess --> S1.onDeleteSuccess
--> S2.onDeleteSuccess
we want:
S1(DS1) -> onDelete() --> DS1.delete --> DS1.success --> A1.onDeleteSuccess --> S1.onDeleteSuccess
S2(DS2) -> onDelete() --> DS2.delete --> DS2.success --> A2.onDeleteSuccess --> S2.onDeleteSuccess
--> DS1 must be replaced from singleton to parametrized class with action
aurambaj
force-pushed
the
refacto_delete_screenshot
branch
from
67169ca
to
89a6ef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.