Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(env): ENG-5157 bundle only one env in release mode #2686

Merged
merged 1 commit into from Apr 29, 2024

Conversation

crherman7
Copy link
Contributor

@crherman7 crherman7 commented Apr 24, 2024

Describe your changes

In release mode only bundle one env - equality test will look directly at file name rather than regex.

Issue ticket number and link

Ticket

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Test Plan

  1. yarn install
  2. yarn build
  3. cd apps/example
  4. yarn flagship-code prebuild --env prod --build internal --release
  5. go to node_modules/@brandingbrand/fsapp/src/project_env_index.js
  6. verify only one env

Checklist before requesting a review

  • A self-review of my code has been completed
  • Tests have been added / updated if required
  • Documentation has been updated to reflect these changes

@crherman7 crherman7 marked this pull request as ready for review April 24, 2024 20:19
@crherman7 crherman7 added the v13 label Apr 24, 2024
@NickBurkhartBB NickBurkhartBB merged commit 7427b34 into brandingbrand:v13 Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants