Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Notification ads are shown when playing media (uplift to 1.67.x) #23585

Merged
merged 1 commit into from May 14, 2024
Merged

[ads] Notification ads are shown when playing media (uplift to 1.67.x) #23585

merged 1 commit into from May 14, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 11, 2024 •
edited by kjozwiak

Uplift of #23584
Resolves brave/brave-browser#38225

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner May 11, 2024 14:13
@kjozwiak kjozwiak added this to the 1.67.x - Beta milestone May 14, 2024
kjozwiak
kjozwiak approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.67.x approved 👍 QA verified the above on Nightly using 1.68.x as per #23584 (comment).

@kjozwiak kjozwiak merged commit 71687b4 into 1.67.x May 14, 2024
14 of 15 checks passed
@kjozwiak kjozwiak deleted the pr23584_issues/38225_1.67.x branch May 14, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.67.x - Beta
2 participants
@brave-builds @kjozwiak