Display source options in alphabetical order.

The Source select list when creating or editing a story or media document now lists sources in alphabetical order. Reported by Michael Herring [#138 state:resolved].
bricoleurs · Mar 10, 2010 · 2659f18 · 2659f18
1 parent 8f7c854
commit 2659f18
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 28 deletions.
diff --git a/comp/widgets/media_prof/edit_meta.html b/comp/widgets/media_prof/edit_meta.html
@@ -70,13 +70,14 @@
    key => 'description',
 &>
 <& '/widgets/select_object/select_object.mc',
-  object   => 'source',
-  name     => "$widget|source__id",
-  field    => 'source_name',
-  selected => $media->get_source__id,
-  indent   => 0,
-  useTable => 1,
-  disp     => "Source"
+  object     => 'source',
+  name       => "$widget|source__id",
+  field      => 'source_name',
+  sort_field => 'source_name',
+  selected   => $media->get_source__id,
+  indent     => 0,
+  useTable   => 1,
+  disp       => "Source"
 &>
 
 % unless (ENABLE_CATEGORY_BROWSER) {

diff --git a/comp/widgets/media_prof/edit_new.html b/comp/widgets/media_prof/edit_new.html
@@ -43,12 +43,13 @@
 &>
 % }
 <& /widgets/select_object/select_object.mc,
-   disp     => 'Source',
-   object   => 'source',
-   name     => "$widget|source__id",
-   field    => 'source_name',
-   selected => $sel_source,
-   useTable => 1,
+   disp       => 'Source',
+   object     => 'source',
+   name       => "$widget|source__id",
+   field      => 'source_name',
+   sort_field => 'source_name',
+   selected   => $sel_source,
+   useTable   => 1,
 &>
 <& /widgets/select_object/select_object.mc,
    object      => 'category',

diff --git a/comp/widgets/story_prof/edit_meta.html b/comp/widgets/story_prof/edit_meta.html
@@ -79,14 +79,15 @@
 
 <div class="editmeta">
 <& '/widgets/select_object/select_object.mc',
-  object   => 'source',
-  name     => "$widget|source__id",
-  field    => 'source_name',
-  selected => $story->get_source__id,
-  indent   => 0,
-  useTable => 1,
-  disp     => "Source",
-  exclude => sub { !chk_authz($_[0], READ, 1) },
+  object     => 'source',
+  name       => "$widget|source__id",
+  field      => 'source_name',
+  sort_field => 'source_name',
+  selected   => $story->get_source__id,
+  indent     => 0,
+  useTable   => 1,
+  disp       => "Source",
+  exclude    => sub { !chk_authz($_[0], READ, 1) },
 &>
 <& '/widgets/profile/displayFormElement.mc',
    objref => $story,

diff --git a/comp/widgets/story_prof/edit_new.html b/comp/widgets/story_prof/edit_new.html
@@ -42,13 +42,14 @@
         );
 
 $m->comp( '/widgets/select_object/select_object.mc',
-          disp     => 'Source',
-          object   => 'source',
-          name     => "$widget|source__id",
-          field    => 'source_name',
-          localize => 0,
-          useTable => 1,
-          exclude  => $excl_sub,
+          disp       => 'Source',
+          object     => 'source',
+          name       => "$widget|source__id",
+          field      => 'source_name',
+          sort_field => 'source_name',
+          localize   => 0,
+          useTable   => 1,
+          exclude    => $excl_sub,
         );
 
 $m->comp( '/widgets/select_object/select_object.mc',

diff --git a/lib/Bric/Changes.pod b/lib/Bric/Changes.pod
@@ -28,6 +28,12 @@ The installer no longer requires that L<Term::ReadPassword> be installed from
 the CPAN before it continues. It will use it if it finds it, but if not
 substitutes a simple implementation that does the trick (Bug #136). [David]
 
+=item *
+
+The Source select list when creating or editing a story or media document now
+lists sources in alphabetical order. Reported by Michael Herring (Bug # 138).
+[David]
+
 =back
 
 =head2 Bug Fixes