Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Paths when loading Transforms #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonnyreeves
Copy link

Pass the collection of paths through to resolve to support environments with 'interesting' node module environments ala https://github.com/tkellen/js-liftoff/pull/44/files

Patched up a minor bug in an error message whilst I was here as well.

@jonnyreeves
Copy link
Author

ping @zertosh

@zertosh
Copy link
Member

zertosh commented Aug 5, 2015

params gets passed to resolve as opts, where it's given a default value of []. By passing self.paths, it'll actually get a value. I think there's an expectation that modules have within their path resolution hierarchy the transform they need, so you shouldn't be passing in paths for that.

Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants