Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node creation with default configuration (i.e. no <configure/>) #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashward
Copy link
Contributor

@ashward ashward commented Jul 16, 2014

Brings the server more in line with XEP-0060, and fixes #200 by allowing node creation without specifying a configure element.

@imaginator
Copy link
Member

Thanks Ash. I'll defer to @lloydwatkin's review - but this sounds sensible.

@lloydwatkin
Copy link
Member

Hi @ashward sorry for taking so long to look at this, need to work out the consequences for later configuration updates and for publishing before configuration has taken place.

@imaginator
Copy link
Member

@lloydwatkin wouldn't it make sense to always populate the config - even if with default values and null strings for title and description. Then if someone does pass a config option it overrides the default?

@lloydwatkin
Copy link
Member

I still need to look into this as we (read: I) made some changes around node format and updating after its been set.

@lloydwatkin
Copy link
Member

Sorry this has been so long @ashward, could you merge in master and I'll get into master ASAP. Looks like the work around preventing node content type changes when there's posts was discussions rather than actual code, so I'll bear this PR in mind when I add that functionality.

@denisw denisw force-pushed the master branch 8 times, most recently from 1faa311 to 42774a5 Compare September 19, 2015 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a node with no config form causes an error
3 participants