Merge pull request #3133 from dragon512/win32-pid-fix

add tweaks to allow buildbot to start and stop nicely on win32

master/buildbot/scripts/start.py

@@ -114,9 +114,13 @@ def launch(config):
             "--python=buildbot.tac"]
 
     # ProcessProtocol just ignores all output
-    reactor.spawnProcess(
+    proc = reactor.spawnProcess(
         protocol.ProcessProtocol(), sys.executable, argv, env=os.environ)
 
+    if platformType == "win32":
+        with open("twistd.pid", "w") as pidfile:
+            pidfile.write("{0}".format(proc.pid))
+
 
 def start(config):
     if not base.isBuildmasterDir(config['basedir']):

master/buildbot/scripts/stop.py

@@ -22,6 +22,8 @@
 import signal
 import time
 
+from twisted.python.runtime import platformType
+
 from buildbot.scripts import base
 
 
@@ -51,7 +53,7 @@ def stop(config, signame="TERM", wait=None):
     try:
         os.kill(pid, signum)
     except OSError as e:
-        if e.errno != errno.ESRCH:
+        if e.errno != errno.ESRCH and platformType != "win32":
             raise
         else:
             if not config['quiet']: