Skip to content

Commit

Permalink
Get results of build in StatusPush handler
Browse files Browse the repository at this point in the history
The 'buildFinished' event indicates to the StatusPush callback that
the build is complete.  Considering that all steps of the build have
completed, it's useful to know whether they all completed
successfully or otherwise.

This is easy to accomplish because StatusPush::buildFinished already
has the success/error value available. Simply push it with the rest of
the event onto the queue.
  • Loading branch information
burrows committed Oct 2, 2015
1 parent 54bf1f1 commit 2fe967d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion master/buildbot/status/status_push.py
Expand Up @@ -340,7 +340,7 @@ def stepFinished(self, build, step, results):
d.addErrback(log.err, 'while pushing status message')

def buildFinished(self, builderName, build, results):
d = self.push('buildFinished', build=build)
d = self.push('buildFinished', build=build, results=results)
d.addErrback(log.err, 'while pushing status message')

def builderRemoved(self, builderName):
Expand Down

0 comments on commit 2fe967d

Please sign in to comment.