fix review comments

buildbot · Dec 6, 2016 · 5054320 · 5054320
1 parent c473868
commit 5054320
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/master/buildbot/test/fake/httpclientservice.py b/master/buildbot/test/fake/httpclientservice.py
@@ -60,8 +60,8 @@ class HTTPClientService(service.SharedService):
     quiet = False
 
     def __init__(self, base_url, auth=None, headers=None):
-        service.SharedService.__init__(self)
         assert not base_url.endswith("/"), "baseurl should not end with /"
+        service.SharedService.__init__(self)
         self._base_url = base_url
         self._auth = auth
 

diff --git a/master/buildbot/util/httpclientservice.py b/master/buildbot/util/httpclientservice.py
@@ -88,8 +88,8 @@ class HTTPClientService(service.SharedService):
     MAX_THREADS = 5
 
     def __init__(self, base_url, auth=None, headers=None):
-        service.SharedService.__init__(self)
         assert not base_url.endswith("/"), "baseurl should not end with /: " + base_url
+        service.SharedService.__init__(self)
         self._base_url = base_url
         self._auth = auth
         self._headers = headers