minor style cleanup of change_hook

buildbot · Oct 6, 2010 · 5e920d5 · 5e920d5
1 parent 4e1d14e
commit 5e920d5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/master/buildbot/status/web/hooks/github.py b/master/buildbot/status/web/hooks/github.py
@@ -120,11 +120,11 @@ def process_change(payload, user, repo, repo_url):
         else: 
             for commit in payload['commits']:
                 files = []
-                if 'added' in commit.keys():
+                if 'added' in commit:
                     files.extend(commit['added'])
-                if 'modified' in commit.keys():
+                if 'modified' in commit:
                     files.extend(commit['modified'])
-                if 'removed' in commit.keys():
+                if 'removed' in commit:
                     files.extend(commit['removed'])
                 when =  convertTime( commit['timestamp'])
                 change = {'revision': commit['id'],

diff --git a/master/buildbot/test/unit/test_status_web_change_hook.py b/master/buildbot/test/unit/test_status_web_change_hook.py
@@ -79,7 +79,6 @@ def setUp(self):
                        "revlink" : ["a revlink"],
                        "properties" : [json.dumps( { "prop1" : "val1", "prop2" : "val2" })],
                        "revision" : [99] }
-        #print changeDict
         self.request = MockRequest(changeDict)
         self.changeHook = change_hook.ChangeHookResource(dialects={'base' : True})
 
@@ -90,7 +89,6 @@ def testDefaultDialectWithChange(self):
         ret = self.changeHook.render_GET(self.request)
         # Change is an array of dicts holding changes. There will normally only be one
         # changes, thus only one dictionary
-        #print ret
         changeArray = json.loads(ret)
         change = changeArray[0]
         self.assertEquals(change["category"], "mycat")