MySQL doesn't like default vals for text fields.

Don't try to pass them if the DB api is MySQLdb. Fixes #776.
buildbot · Oct 4, 2010 · 790ba89 · 790ba89
1 parent b713e2f
commit 790ba89
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/master/buildbot/db/schema/v2.py b/master/buildbot/db/schema/v2.py
@@ -7,23 +7,28 @@ def upgrade(self):
         self.set_version()
 
     def add_columns(self):
+        if self.dbapiName == 'MySQLdb':
+            default_text = ""
+        else:
+            default_text = "default ''"
+
         cursor = self.conn.cursor()
         cursor.execute("""
         ALTER TABLE changes
-            add column `repository` text not null default ''
-        """)
+            add column `repository` text not null %s
+        """ % default_text)
         cursor.execute("""
         ALTER TABLE changes
-            add column `project` text not null default ''
-        """)
+            add column `project` text not null %s
+        """ % default_text)
         cursor.execute("""
         ALTER TABLE sourcestamps
-            add column `repository` text not null default ''
-        """)
+            add column `repository` text not null %s
+        """ % default_text)
         cursor.execute("""
         ALTER TABLE sourcestamps
-            add column `project` text not null default ''
-        """)
+            add column `project` text not null %s
+        """ % default_text)
 
     def set_version(self):
         c = self.conn.cursor()