ForceScheduler: Check than one pass a list to the codebases parameter.

buildbot · Oct 22, 2014 · 849c885 · 849c885
1 parent 130751b
commit 849c885
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/master/buildbot/schedulers/forcesched.py b/master/buildbot/schedulers/forcesched.py
@@ -636,7 +636,9 @@ def __init__(self, name, builderNames,
         if codebases is None:
             codebases = [CodebaseParameter(codebase='')]
         elif not codebases:
-            config.error("ForceScheduler: 'codebases' cannot be empty; use CodebaseParameter(codebase='', hide=True) if needed: %r " % (codebases,))
+            config.error("ForceScheduler: 'codebases' cannot be empty; use [CodebaseParameter(codebase='', hide=True)] if needed: %r " % (codebases,))
+        elif not isinstance(codebases, list):
+            config.error("ForceScheduler: 'codebases' should be a list of strings or CodebaseParameter, not %s" % type(codebases))
 
         codebase_dict = {}
         for codebase in codebases: