Skip to content

Commit

Permalink
don't use '--dirty' in git invocations, since older gits don't suppor…
Browse files Browse the repository at this point in the history
…t it
  • Loading branch information
Dustin J. Mitchell committed Oct 1, 2010
1 parent bfea855 commit 84ea252
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions master/buildbot/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
version = open(fn).read().strip()

except IOError:
from subprocess import Popen, PIPE
from subprocess import Popen, PIPE, STDOUT
import re

VERSION_MATCH = re.compile(r'\d+\.\d+\.\d+(\w|-)*')

try:
p = Popen(['git', 'describe', '--tags', '--always', '--dirty'], stdout=PIPE)
p = Popen(['git', 'describe', '--tags', '--always'], stdout=PIPE, stderr=STDOUT)
out = p.communicate()[0]

if (not p.returncode) and out:
Expand Down
4 changes: 2 additions & 2 deletions slave/buildslave/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
version = open(fn).read().strip()

except IOError:
from subprocess import Popen, PIPE
from subprocess import Popen, PIPE, STDOUT
import re

VERSION_MATCH = re.compile(r'\d+\.\d+\.\d+(\w|-)*')

try:
p = Popen(['git', 'describe', '--tags', '--always', '--dirty'], stdout=PIPE)
p = Popen(['git', 'describe', '--tags', '--always'], stdout=PIPE, stderr=STDOUT)
out = p.communicate()[0]

if (not p.returncode) and out:
Expand Down

0 comments on commit 84ea252

Please sign in to comment.