Skip to content

Commit

Permalink
add an isSkipped method to BuildStepStatus
Browse files Browse the repository at this point in the history
Fixes #879
  • Loading branch information
Dustin J. Mitchell committed Oct 22, 2010
1 parent e8548b7 commit a46cf0d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions master/buildbot/process/buildstep.py
Expand Up @@ -770,6 +770,7 @@ def _startStep_2(self, res):

if skip == SKIPPED:
self.step_status.setText(self.describe(True) + ['skipped'])
self.step_status.setSkipped(True)
# this return value from self.start is a shortcut
# to finishing the step immediately
reactor.callLater(0, self.finished, SKIPPED)
Expand Down
7 changes: 7 additions & 0 deletions master/buildbot/status/builder.py
Expand Up @@ -836,6 +836,7 @@ def __init__(self, parent, step_number):
self.updates = {}
self.finishedWatchers = []
self.statistics = {}
self.skipped = False

self.waitingForLocks = False

Expand Down Expand Up @@ -871,6 +872,9 @@ def getURLs(self):
def isStarted(self):
return (self.started is not None)

def isSkipped(self):
return self.skipped

def isFinished(self):
return (self.finished is not None)

Expand Down Expand Up @@ -1025,6 +1029,9 @@ def setStatistic(self, name, value):
"""
self.statistics[name] = value

def setSkipped(self, skipped):
self.skipped = skipped

def stepFinished(self, results):
self.finished = util.now()
self.results = results
Expand Down

0 comments on commit a46cf0d

Please sign in to comment.