ensure that summaryUnsubscribe succeeds

`summaryUnsubscribe` shoud be callable even if `summarySubscribe` hasn't been called. Fixes #2756.
buildbot · Apr 14, 2014 · cf4c10c · cf4c10c
1 parent d3364bf
commit cf4c10c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/master/buildbot/status/buildset.py b/master/buildbot/status/buildset.py
@@ -74,6 +74,8 @@ def asDict(self):
 
 class BuildSetSummaryNotifierMixin:
 
+    _buildSetSubscription = None
+
     def summarySubscribe(self):
         self._buildSetSubscription = self.master.subscribeToBuildsetCompletions(self._buildsetComplete)
 

diff --git a/master/buildbot/test/unit/test_status_buildset.py b/master/buildbot/test/unit/test_status_buildset.py
@@ -95,3 +95,7 @@ def check(_):
             self.assertEqual(builds, info['builds'])
 
             self.assertEqual(buildset['bsid'], info['bsid'])
+
+    def test_unsub_with_no_sub(self):
+        notifier = BuildSetSummaryNotifierMixin()
+        notifier.summaryUnsubscribe()