Skip to content

Commit

Permalink
buildbot.service: better handle error
Browse files Browse the repository at this point in the history
fix for 2960

In case of 404, the buildbot.service was storing the 404 error instead of retrying next time

Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
  • Loading branch information
Pierre Tardy committed Oct 29, 2014
1 parent 4ccffe6 commit cfff761
Showing 1 changed file with 5 additions and 1 deletion.
Expand Up @@ -106,6 +106,10 @@ class BuildbotService extends Factory
elem.on("*", onUpdate).then (unsub) ->
events.push(unsub)
return res
, (res) ->
elem.value = null
bound = false
return $q.reject(res)
elem.value = p
return p

Expand Down Expand Up @@ -181,4 +185,4 @@ class BuildbotService extends Factory
l.push(r.bind($scope))
return $q.all(l)
addSomeAndMemoize(self)
return self
return self

0 comments on commit cfff761

Please sign in to comment.