Skip to content

Commit

Permalink
removing commented out try/except block
Browse files Browse the repository at this point in the history
  • Loading branch information
PerilousApricot committed Aug 13, 2010
1 parent 185528f commit d6400a8
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions master/buildbot/status/web/change_hook.py
Expand Up @@ -79,15 +79,11 @@ def getChanges(self, request):
dialect = 'base'

if dialect in self.dialects.keys():
# try:
# note, this should be safe, only alphanumerics and _ are
# allowed in the dialect name
msg("Attempting to load module buildbot.status.web.hooks" + dialect)
tempModule = namedModule('buildbot.status.web.hooks.' + dialect)
changes = tempModule.getChanges(request,self.dialects[dialect])
msg("Got the following changes %s" % changes)
# except:
# err("Encountered an exception in change_hook:")

else:
msg("The dialect specified %s wasn't whitelisted in change_hook" % dialect)
msg("Note: if dialect is 'base' then it's possible your URL is malformed and we didn't regex it properly")
Expand Down

0 comments on commit d6400a8

Please sign in to comment.