Skip to content

Commit

Permalink
Mark a buildset FAILED if anything was worse than WARNINGS
Browse files Browse the repository at this point in the history
In particular, if a build's result was EXCEPTION, this will cause the
whole buildset to be represented as FAILED in the database.  This has
implications for downstream schedulers, but not for the web status.

Fixes #969
  • Loading branch information
Dustin J. Mitchell committed Aug 18, 2010
1 parent 9866680 commit ea9c2a8
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions master/buildbot/db/connector.py
Expand Up @@ -955,8 +955,10 @@ def _check_buildset(self, t, bsid, now):
if not complete:
# still waiting
is_complete = False
if r == FAILURE:
bs_results = r
# mark the buildset as a failure if anything worse than
# WARNINGS resulted from any one of the buildrequests
if r not in (SUCCESS, WARNINGS):
bs_results = FAILURE
if is_complete:
# they were all successful
q = self.quoteq("UPDATE buildsets"
Expand Down

0 comments on commit ea9c2a8

Please sign in to comment.