amend default value for missing_timeout to 10 minutes

buildbot · Mar 25, 2015 · f746d7f · f746d7f
1 parent 139dbb8
commit f746d7f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/master/buildbot/buildslave/base.py b/master/buildbot/buildslave/base.py
@@ -55,7 +55,8 @@ class AbstractBuildSlave(service.ReconfigurableServiceMixin,
     reconfig_priority = 64
 
     def __init__(self, name, password, max_builds=None,
-                 notify_on_missing=None, missing_timeout=3600,
+                 notify_on_missing=None,
+                 missing_timeout=10 * 60,   # Ten minutes
                  properties=None, locks=None, keepalive_interval=3600):
         """
         @param name: botname this machine will supply when it connects

diff --git a/master/buildbot/test/unit/test_buildslave_base.py b/master/buildbot/test/unit/test_buildslave_base.py
@@ -154,7 +154,7 @@ def test_constructor_minimal(self):
         self.assertEqual(bs.password, 'pass')
         self.assertEqual(bs.max_builds, None)
         self.assertEqual(bs.notify_on_missing, [])
-        self.assertEqual(bs.missing_timeout, 3600)
+        self.assertEqual(bs.missing_timeout, 10 * 60)
         self.assertEqual(bs.properties.getProperty('slavename'), 'bot')
         self.assertEqual(bs.access, [])
 

diff --git a/master/buildbot/test/unit/test_buildslave_libvirt.py b/master/buildbot/test/unit/test_buildslave_libvirt.py
@@ -50,7 +50,7 @@ def test_constructor_minimal(self):
         self.assertEqual(bs.image, 'path')
         self.assertEqual(bs.base_image, 'otherpath')
         # XXX(sa2ajj): interesting test, this probably needs to be an external constant
-        self.assertEqual(bs.missing_timeout, 3600)
+        self.assertEqual(bs.missing_timeout, 10 * 60)
 
     @defer.inlineCallbacks
     def test_find_existing(self):