Rest: Filter buildsets by sourcestamp attributes #6518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jangmarker
commented
May 14, 2022
jangmarker
force-pushed
the
filter-buildset-by-sourcestamp
branch
from
c987817
to
6d1242b
Compare
Codecov Report
@@ Coverage Diff @@
## master #6518 +/- ##
==========================================
- Coverage 92.08% 92.04% -0.05%
==========================================
Files 343 343
Lines 38636 38660 +24
==========================================
+ Hits 35578 35583 +5
- Misses 3058 3077 +19
Continue to review full report at Codecov.
|
Allow the buildsets REST endpoint to filter by sourcestamp attributes.
We use the 'contains' relation to filter by a set of sourcestamp attributes:
buildsets?sourcestamps__contains={"ssid":26}
The list of buildsets is then only listing buildsets that have a
sourcestamp with that ssid. If the sourcestamps__contains filter is used
multiple times it follows the "or" semantics like the other filters. If
a single filter lists multiple attributes these follow and semantics,
within the filter.
sourcestamps are encoded as JSON in the REST query.
The filters are implemented on SQL-level. Necessary joins are only
performed if this filter is actually used.
jangmarker
force-pushed
the
filter-buildset-by-sourcestamp
branch
from
6d1242b
to
dc4ae9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before implementing unit tests I'd first like to confirm that this approach can go forward. Open questions that I need feedback on:
Description
Allow the buildsets REST endpoint to filter by sourcestamp attributes.
We use the 'contains' relation to filter by a set of sourcestamp attributes:
buildsets?sourcestamps__contains={"ssid":26}The list of buildsets is then only listing buildsets that have a
sourcetsamp with that ssid. If the sourcestamps__contains filter is used
multiple times it follows the "or" semantics like the other filters. If
a single filter lists multiple attributes these follow and semantics,
within the filter.
The filters are implemented on SQL-level. Necessary joins are only
performed if this filter is actually used.
Contributor Checklist:
newsfragmentsdirectory (and read theREADME.txtin that directory)