test: Actually wait for text to match the builder name #7531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
reviewed
Apr 28, 2024
A test randomly breaks, due to waiting for the first text that showed up and trying to match it with a builder name. This commit fixes the problem by actually waiting for updated text to match the builder name.
mokibit
force-pushed
the
test-wait-for-text-to-mach-builder-name
branch
from
5bdc757
to
e224a45
Compare
p12tic
approved these changes
Apr 28, 2024
This was referenced Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues #7410 and #7407.
"pending build requests › shows" e2e test sometimes fails, due to waiting for the first text that showed up and trying to match it with a builder name.
This commit fixes the problem by actually waiting for updated text to match the builder name
Contributor Checklist:
newsfragmentsdirectory (and read theREADME.txtin that directory)