Two bugs about data type #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t has no attribute isdigit'. Changed the file saving line to include the compression in the to_csv arguments. This avoids error about something needs to be bytes like and not string...
tpoterba
requested changes
Nov 21, 2019
| @@ -29,8 +29,7 @@ def make_annot_files(args, bed_for_annot): | |||
| df_annot.fillna(0, inplace=True) | |||
| df_annot = df_annot[['ANNOT']].astype(int) | |||
| if args.annot_file.endswith('.gz'): | |||
| with gzip.open(args.annot_file, 'wb') as f: | |||
| df_annot.to_csv(f, sep = "\t", index = False) | |||
| df_annot.to_csv(args.annot_file, sep = "\t", index = False, compression='\gzip') | |||
There was a problem hiding this comment.
Can we get rid of the backslash on \gzip?
There was a problem hiding this comment.
also, pandas 0.24 can infer compression based on extension, but not in 0.20 which we're pinned to (bummer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying int type for x2 in iter_bim fixes error 'numpy.int64 object has no attribute isdigit'. Changed the file saving line to include the compression in the to_csv arguments. This avoids error about something needs to be bytes like and not string...