Add str len check in config_sortlist to avoid stack overflow #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ares_set_sortlist
, it callsconfig_sortlist(..., sortstr)
to parse the input str and initialize a sortlist configuration.However,
ares_set_sortlist
has not any checks about the validity of the input str. It is very easy to create an arbitrary length stack overflow with the uncheckedmemcpy(ipbuf, str, q-str);
andmemcpy(ipbufpfx, str, q-str);
statements in the config_sortlist call, which could potentially cause severe security impact in practical programs.This commit add necessary check for
ipbuf
andipbufpfx
which avoid the potential stack overflows.fixes #496
Signed-off-by: hopper-vul hopper.vul@gmail.com