Moving error handler inclusion to before Configure::bootstrap() so ap…

…p error handlers can be created.

Fixing issue where unknown exception types would not be handled spewing out errors.  Unknown exception types are interpreted as 500 errors.

cake/bootstrap.php

@@ -33,7 +33,8 @@
 require LIBS . 'configure.php';
 require LIBS . 'set.php';
 require LIBS . 'cache.php';
-Configure::bootstrap();
 require LIBS . 'error_handler.php';
 set_exception_handler(array('ErrorHandler', 'handleException'));
+
+Configure::bootstrap();
 require CAKE . 'dispatcher.php';

cake/libs/error_handler.php

@@ -62,7 +62,9 @@ class ErrorHandler {
 	public $error = null;
 
 /**
- * Class constructor.
+ * Creates the controller to perform rendering on the error response.
+ * If the error is a CakeException it will be converted to either a 404 or a 500 
+ * type error depending on the code used to construct the error.
  *
  * @param string $method Method producing the error
  * @param array $messages Error messages
@@ -79,6 +81,8 @@ function __construct(Exception $exception) {
 
 		if ($exception instanceof CakeException && !in_array($method, get_class_methods($this))) {
 			$method = '_cakeError';
+		} elseif (!method_exists($this, $method)) {
+			$method = 'error500';
 		}
 
 		if ($method !== 'error' && Configure::read('debug') == 0) {

cake/tests/cases/libs/error_handler.test.php

@@ -330,6 +330,19 @@ function testErrorMethodCoercion() {
 		$this->assertEquals($exception, $ErrorHandler->error);
 	}
 
+/**
+ * test that unknown exception types are captured and converted to 500
+ *
+ * @return void
+ */
+	function testUnknownExceptionType() {
+		$exception = new MissingWidgetThingException('coding fail.');
+		$ErrorHandler = new ErrorHandler($exception);
+
+		$this->assertFalse(method_exists($ErrorHandler, 'missingWidgetThing'), 'no method should exist.');
+		$this->assertEquals('error500', $ErrorHandler->method, 'incorrect method coercion.');
+	}
+
 /**
  * testError method
  *