Added try/catch block into ErrorHandler::handleException() to gracefu…

…lly show Exceptions raised during exception handling. Fixes #1707
cakephp · May 17, 2011 · 085c621 · 085c621
1 parent 6289f20
commit 085c621
Showing 1 changed file with 25 additions and 14 deletions.
diff --git a/lib/Cake/Error/ErrorHandler.php b/lib/Cake/Error/ErrorHandler.php
@@ -107,22 +107,32 @@ class ErrorHandler {
  * @see http://php.net/manual/en/function.set-exception-handler.php
  */
 	public static function handleException(Exception $exception) {
-		$config = Configure::read('Exception');
-		if (!empty($config['log'])) {
-			$message = sprintf("[%s] %s\n%s",
-				get_class($exception),
-				$exception->getMessage(),
-				$exception->getTraceAsString()
+		try {
+			$config = Configure::read('Exception');
+			if (!empty($config['log'])) {
+				$message = sprintf("[%s] %s\n%s",
+					get_class($exception),
+					$exception->getMessage(),
+					$exception->getTraceAsString()
+				);
+				CakeLog::write(LOG_ERR, $message);
+			}
+			$renderer = $config['renderer'];
+			if ($renderer !== 'ExceptionRenderer') {
+				list($plugin, $renderer) = pluginSplit($renderer, true);
+				App::uses($renderer, $plugin . 'Error');
+			}
+			$error = new $renderer($exception);
+			$error->render();
+		} catch (Exception $e) {
+			$message = $e->getMessage()."\nCall Stack:\n".$e->getTraceAsString();
+			ErrorHandler::handleError(
+				E_ERROR,
+				$message,
+				$e->getFile(),
+				$e->getLine()
 			);
-			CakeLog::write(LOG_ERR, $message);
-		}
-		$renderer = $config['renderer'];
-		if ($renderer !== 'ExceptionRenderer') {
-			list($plugin, $renderer) = pluginSplit($renderer, true);
-			App::uses($renderer, $plugin . 'Error');
 		}
-		$error = new $renderer($exception);
-		$error->render();
 	}
 
 /**
@@ -178,6 +188,7 @@ public static function handleError($code, $description, $file = null, $line = nu
  * @return array Array of error word, and log location.
  */
 	protected static function _mapErrorCode($code) {
+		$error = $log = null;
 		switch ($code) {
 			case E_PARSE:
 			case E_ERROR: