Fix ini_set calls to use strings as second parameter

cakephp · Jun 19, 2017 · 09a18a7 · 09a18a7
1 parent 1ec80bd
commit 09a18a7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/Console/ShellDispatcher.php b/src/Console/ShellDispatcher.php
@@ -142,9 +142,9 @@ protected function _initEnvironment()
         }
 
         if (function_exists('ini_set')) {
-            ini_set('html_errors', false);
-            ini_set('implicit_flush', true);
-            ini_set('max_execution_time', 0);
+            ini_set('html_errors', '0');
+            ini_set('implicit_flush', '1');
+            ini_set('max_execution_time', '0');
         }
 
         $this->shiftArgs();

diff --git a/src/Core/Configure.php b/src/Core/Configure.php
@@ -96,7 +96,7 @@ public static function write($config, $value = null)
                 static::$_hasIniSet = function_exists('ini_set');
             }
             if (static::$_hasIniSet) {
-                ini_set('display_errors', $config['debug'] ? 1 : 0);
+                ini_set('display_errors', $config['debug'] ? '1' : '0');
             }
         }
 

diff --git a/tests/TestCase/Network/Session/DatabaseSessionTest.php b/tests/TestCase/Network/Session/DatabaseSessionTest.php
@@ -154,7 +154,7 @@ public function testGc()
     {
         TableRegistry::clear();
 
-        ini_set('session.gc_maxlifetime', 0);
+        ini_set('session.gc_maxlifetime', '0');
         $storage = new DatabaseSession();
         $storage->write('foo', 'Some value');