Avoid unnecessarily generating separator string multiple times.

cakephp · Oct 5, 2016 · 0c17f71 · 0c17f71
1 parent f9e3b56
commit 0c17f71
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/View/Helper/BreadcrumbsHelper.php b/src/View/Helper/BreadcrumbsHelper.php
@@ -217,6 +217,7 @@ public function render(array $attributes = [], array $separator = [])
         $crumbs = $this->crumbs;
         $crumbsCount = count($crumbs);
         $templater = $this->templater();
+        $separatorString = '';
 
         if ($separator) {
             if (isset($separator['innerAttrs'])) {
@@ -227,6 +228,8 @@ public function render(array $attributes = [], array $separator = [])
                 $separator,
                 ['innerAttrs', 'separator']
             );
+
+            $separatorString = $this->formatTemplate('separator', $separator);
         }
 
         $crumbTrail = '';
@@ -255,8 +258,8 @@ public function render(array $attributes = [], array $separator = [])
                 $template = 'itemWithoutLink';
             }
 
-            if ($separator && $key !== ($crumbsCount - 1)) {
-                $templateParams['separator'] = $this->formatTemplate('separator', $separator);
+            if ($separatorString && $key !== ($crumbsCount - 1)) {
+                $templateParams['separator'] = $separatorString;
             }
 
             $crumbTrail .= $this->formatTemplate($template, $templateParams);