Update PhpConfig::dump() to generate file which returns array.

cakephp · Jan 14, 2015 · 1884d7b · 1884d7b
1 parent c3d23f4
commit 1884d7b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Core/Configure/Engine/PhpConfig.php b/src/Core/Configure/Engine/PhpConfig.php
@@ -90,7 +90,7 @@ public function read($key)
      */
     public function dump($key, array $data)
     {
-        $contents = '<?php' . "\n" . '$config = ' . var_export($data, true) . ';';
+        $contents = '<?php' . "\n" . 'return ' . var_export($data, true) . ';';
 
         $filename = $this->_getFilePath($key);
         return file_put_contents($filename, $contents);

diff --git a/tests/TestCase/Core/Configure/Engine/PhpConfigTest.php b/tests/TestCase/Core/Configure/Engine/PhpConfigTest.php
@@ -145,7 +145,7 @@ public function testDump()
         $this->assertTrue($result > 0);
         $expected = <<<PHP
 <?php
-\$config = array (
+return array (
   'One' => 
   array (
     'two' => 'value',