uses TestCase::skipIf() to reduce code and bring it to top

cakephp · May 30, 2016 · 1a2ccba · 1a2ccba
1 parent ef802cd
commit 1a2ccba
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/tests/TestCase/Network/Http/Auth/OauthTest.php b/tests/TestCase/Network/Http/Auth/OauthTest.php
@@ -298,19 +298,15 @@ public function testRsaSigningWithPassphraseString()
      */
     public function testRsaSigningWithPassphraseFile()
     {
+        $this->skipIf(PHP_EOL != "\n", 'Just the line ending "\n" is supported. You can run the test again e.g. on a linux system.');
+
         $request = new Request();
         $request->url('http://photos.example.net/photos')
             ->body([
                        'file' => 'vacaction.jpg',
                        'size' => 'original'
                    ]);
         $privateKeyPath = TEST_APP . DS . 'config' . DS . 'key_with_passphrase.pem';
-
-        if (PHP_EOL != "\n") {
-            $this->markTestSkipped('Just the line ending ("\n") is supported. You can run the test again e.g. on a linux system.');
-            return;
-        }
-
         $passphrasePath = TEST_APP . DS . 'config' . DS . 'key_passphrase_lf';
         $passphrase = fopen($passphrasePath, 'r');