Fixing issue where _restructureParams would move controller key to th…

…e plugin key causing issues switching controllers. Tests added. Fixes #115
cakephp · Dec 17, 2009 · 1e7e650 · 1e7e650
1 parent 264cdb7
commit 1e7e650
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/cake/dispatcher.php b/cake/dispatcher.php
@@ -420,14 +420,13 @@ function &__getController() {
 				$this->params = $original;
 				return $controller;
 			}
-		} else {
-			if (!isset($params['plugin'])) {
-				$params = $this->_restructureParams($params);
-			}
 		}
 		$name = $ctrlClass;
 		$ctrlClass .= 'Controller';
 		if (class_exists($ctrlClass)) {
+			if (empty($params['plugin']) && strtolower(get_parent_class($ctrlClass)) === strtolower($name . 'AppController')) {
+				$params = $this->_restructureParams($params);
+			}
 			$this->params = $params;
 			$controller =& new $ctrlClass();
 		}

diff --git a/cake/tests/cases/dispatcher.test.php b/cake/tests/cases/dispatcher.test.php
@@ -1321,6 +1321,8 @@ function testDispatch() {
 
 		$url = 'pages/home/';
 		$controller = $Dispatcher->dispatch($url, array('return' => 1));
+		$this->assertNull($controller->plugin);
+		$this->assertNull($Dispatcher->params['plugin']);
 
 		$expected = 'Pages';
 		$this->assertEqual($expected, $controller->name);