Fix subtle error in Regex matching URI scheme.

[+-.] will match plus, hyphen, and dot, but also comma. Use [+\-.] since commas not allowed in URI scheme.
cakephp · Jun 21, 2013 · 1ff77f2 · 1ff77f2
1 parent 2fd36bd
commit 1ff77f2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/Cake/Routing/Router.php b/lib/Cake/Routing/Router.php
@@ -888,7 +888,7 @@ public static function url($url = null, $full = false) {
 				$output .= Inflector::underscore($params['controller']) . '/' . $url;
 			}
 		}
-		$protocol = preg_match('#^[a-z][a-z0-9+-.]*\://#i', $output);
+		$protocol = preg_match('#^[a-z][a-z0-9+\-.]*\://#i', $output);
 		if ($protocol === 0) {
 			$output = str_replace('//', '/', $base . '/' . $output);