Fixed issue where query would be executed twice if used inside a coll…

…ection
cakephp · Mar 12, 2015 · 23fd927 · 23fd927
1 parent bba6bb2
commit 23fd927
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/src/Database/Statement/StatementDecorator.php b/src/Database/Statement/StatementDecorator.php
@@ -46,6 +46,13 @@ class StatementDecorator implements StatementInterface, \Countable, \IteratorAgg
      */
     protected $_driver;
 
+    /**
+     * Whether or not this statement has already been executed
+     *
+     * @var bool
+     */
+    protected $_hasExecuted = false;
+
     /**
      * Constructor
      *
@@ -158,6 +165,7 @@ public function errorInfo()
      */
     public function execute($params = null)
     {
+        $this->_hasExecuted = true;
         return $this->_statement->execute($params);
     }
 
@@ -228,7 +236,6 @@ public function rowCount()
      *
      * ```
      * $statement = $connection->prepare('SELECT id, title from articles');
-     * $statement->execute();
      * foreach ($statement as $row) {
      *   //do stuff
      * }
@@ -238,7 +245,9 @@ public function rowCount()
      */
     public function getIterator()
     {
-        $this->execute();
+        if (!$this->_hasExecuted) {
+            $this->execute();
+        }
         return $this->_statement;
     }
 

diff --git a/tests/TestCase/Database/Statement/StatementDecoratorTest.php b/tests/TestCase/Database/Statement/StatementDecoratorTest.php
@@ -44,7 +44,8 @@ public function testLastInsertId()
     }
 
     /**
-     * Tests that calling lastInsertId will get the
+     * Tests that calling lastInsertId will get the last insert id by
+     * column name
      *
      * @return void
      */
@@ -62,4 +63,21 @@ public function testLastInsertIdWithReturning()
         $driver->expects($this->never())->method('lastInsertId');
         $this->assertEquals(2, $statement->lastInsertId('users', 'id'));
     }
+
+    /**
+     * Tests that the statement will not be executed twice if the iterator
+     * is requested more than once
+     *
+     * @return void
+     */
+    public function testNoDoubleExecution() {
+        $inner = $this->getMock('\PDOStatement');
+        $driver = $this->getMock('\Cake\Database\Driver');
+        $statement = new StatementDecorator($inner, $driver);
+
+        $inner->expects($this->once())->method('execute');
+        $this->assertSame($inner, $statement->getIterator());
+        $this->assertSame($inner, $statement->getIterator());
+    }
+
 }