Remove remaining required references from Form\Schema.

The requiredness of a field comes from the field having a validation rule.
cakephp · Dec 20, 2014 · 278a40b · 278a40b
1 parent ffd5d89
commit 278a40b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/Form/Schema.php b/src/Form/Schema.php
@@ -35,7 +35,6 @@ class Schema {
 		'type' => null,
 		'length' => null,
 		'precision' => null,
-		'required' => false,
 	];
 
 /**

diff --git a/tests/TestCase/Form/SchemaTest.php b/tests/TestCase/Form/SchemaTest.php
@@ -51,15 +51,15 @@ public function testAddingFields() {
 
 		$this->assertEquals(['name'], $schema->fields());
 		$res = $schema->field('name');
-		$expected = ['type' => 'string', 'length' => null, 'required' => false];
+		$expected = ['type' => 'string', 'length' => null, 'precision' => null];
 		$this->assertEquals($expected, $res);
 
 		$res = $schema->addField('email', 'string');
 		$this->assertSame($schema, $res, 'Should be chainable');
 
 		$this->assertEquals(['name', 'email'], $schema->fields());
 		$res = $schema->field('email');
-		$expected = ['type' => 'string', 'length' => null, 'required' => false];
+		$expected = ['type' => 'string', 'length' => null, 'precision' => null];
 		$this->assertEquals($expected, $res);
 	}
 
@@ -72,7 +72,7 @@ public function testAddingFieldsWhitelist() {
 		$schema = new Schema();
 
 		$schema->addField('name', ['derp' => 'derp', 'type' => 'string']);
-		$expected = ['type' => 'string', 'length' => null, 'required' => false];
+		$expected = ['type' => 'string', 'length' => null, 'precision' => null];
 		$this->assertEquals($expected, $schema->field('name'));
 	}