Add test assertions and refactor shared code.

Refs #8439
cakephp · Mar 15, 2016 · 2e12b89 · 2e12b89
1 parent 1434029
commit 2e12b89
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 25 deletions.
diff --git a/src/Error/BaseErrorHandler.php b/src/Error/BaseErrorHandler.php
@@ -270,22 +270,11 @@ protected function _logError($level, $data)
                 'start' => 1,
                 'format' => 'log'
             ]);
-            
+
             $request = Router::getRequest();
             if ($request) {
-                $message .= "\nRequest URL: " . $request->here();
-
-                $referer = $request->env('HTTP_REFERER');
-                if ($referer) {
-                    $message .= "\nReferer URL: " . $referer;
-                }
-
-                $clientIp = $request->clientIp();
-                if ($clientIp && $clientIp !== '::1') {
-                    $message .= "\nClient IP: " . $clientIp;
-                }
+                $message .= $this->_requestContext($request);
             }
-
             $message .= "\nTrace:\n" . $trace . "\n";
         }
         $message .= "\n\n";
@@ -319,6 +308,27 @@ protected function _logException(Exception $exception)
         return Log::error($this->_getMessage($exception));
     }
 
+    /**
+     * Get the request context for an error/exception trace.
+     *
+     * @param \Cake\Network\Request $request The request to read from.
+     * @return string
+     */
+    protected function _requestContext($request)
+    {
+        $message = "\nRequest URL: " . $request->here();
+
+        $referer = $request->env('HTTP_REFERER');
+        if ($referer) {
+            $message .= "\nReferer URL: " . $referer;
+        }
+        $clientIp = $request->clientIp();
+        if ($clientIp && $clientIp !== '::1') {
+            $message .= "\nClient IP: " . $clientIp;
+        }
+        return $message;
+    }
+
     /**
      * Generates a formatted error message
      *
@@ -347,17 +357,7 @@ protected function _getMessage(Exception $exception)
 
         $request = Router::getRequest();
         if ($request) {
-            $message .= "\nRequest URL: " . $request->here();
-
-            $referer = $request->env('HTTP_REFERER');
-            if ($referer) {
-                $message .= "\nReferer URL: " . $referer;
-            }
-
-            $clientIp = $request->clientIp();
-            if ($clientIp && $clientIp !== '::1') {
-                $message .= "\nClient IP: " . $clientIp;
-            }
+            $message .= $this->_requestContext($request);
         }
 
         if (!empty($config['trace'])) {

diff --git a/tests/TestCase/Error/ErrorHandlerTest.php b/tests/TestCase/Error/ErrorHandlerTest.php
@@ -222,7 +222,9 @@ public function testHandleErrorLoggingTrace()
                 $this->logicalAnd(
                     $this->stringContains('Notice (8): Undefined variable: out in '),
                     $this->stringContains('Trace:'),
-                    $this->stringContains(__NAMESPACE__ . '\ErrorHandlerTest::testHandleErrorLoggingTrace()')
+                    $this->stringContains(__NAMESPACE__ . '\ErrorHandlerTest::testHandleErrorLoggingTrace()'),
+                    $this->stringContains('Request URL:'),
+                    $this->stringContains('Referer URL:')
                 )
             );