Skip to content

Commit

Permalink
Revert removal of session_cache_limiter()
Browse files Browse the repository at this point in the history
It was removed in [4a6159c].
The session_cache_limiter() is required for IE8 to correctly
hold onto sessions.

Fixes #2781
  • Loading branch information
markstory committed Apr 14, 2012
1 parent 4e1a267 commit 2fd15b6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/Cake/Model/Datasource/CakeSession.php
Expand Up @@ -602,6 +602,8 @@ protected static function _startSession() {
$_SESSION = array();
}
} else {
// For IE<8

This comment has been minimized.

Copy link
@ADmad

ADmad Apr 14, 2012

Member

Shouldn't the comment be //For IE<=8 ?

This comment has been minimized.

Copy link
@markstory

markstory Apr 14, 2012

Author Member

Yeah, I fail at programming today..

session_cache_limiter("must-revalidate");
session_start();
}
return true;
Expand Down

3 comments on commit 2fd15b6

@lorenzo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with this fix, in any case we should do this in the response class and always set the response to private ad other major frameworks do. I don't like magic headers being set around different parts of the framework.

What do you think?

@markstory
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with moving the header setting. But we should not use session_cache_limiter() in that case. I'm pretty sure using session_cache_limiter() needs to be done before session_start(). But we could always set the default cache control headers to the equivalent values.

@lorenzo
Copy link
Member

@lorenzo lorenzo commented on 2fd15b6 Apr 14, 2012 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.