Commit
It was removed in [4a6159c]. The session_cache_limiter() is required for IE8 to correctly hold onto sessions. Fixes #2781
- Loading branch information
There are no files selected for viewing
3 comments
on commit 2fd15b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with this fix, in any case we should do this in the response class and always set the response to private ad other major frameworks do. I don't like magic headers being set around different parts of the framework.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with moving the header setting. But we should not use session_cache_limiter() in that case. I'm pretty sure using session_cache_limiter() needs to be done before session_start(). But we could always set the default cache control headers to the equivalent values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the comment be
//For IE<=8
?